Skip to content

Import image via COS#68

Merged
clnperez merged 1 commit intoopenshift-powervs:add-ipifrom
mjturek:import-from-cos
Nov 11, 2021
Merged

Import image via COS#68
clnperez merged 1 commit intoopenshift-powervs:add-ipifrom
mjturek:import-from-cos

Conversation

@mjturek
Copy link
Copy Markdown

@mjturek mjturek commented Nov 5, 2021

No description provided.

@clnperez
Copy link
Copy Markdown

clnperez commented Nov 8, 2021

can you remove the vendoring?

@mjturek
Copy link
Copy Markdown
Author

mjturek commented Nov 9, 2021

can you remove the vendoring?

I can but then it will not pass CI

@clnperez
Copy link
Copy Markdown

clnperez commented Nov 9, 2021

if you just run go mod tidy but not go mod vendor and add the updated go.sum, then it should get past that CI error

@mjturek mjturek force-pushed the import-from-cos branch 2 times, most recently from 1305628 to 5455301 Compare November 9, 2021 19:04
@mjturek mjturek changed the base branch from add-ipi-20211108 to add-ipi November 9, 2021 19:05
@mjturek mjturek force-pushed the import-from-cos branch 4 times, most recently from 158b2e7 to 337be97 Compare November 9, 2021 22:46
Comment thread pkg/types/powervs/platform.go Outdated
@clnperez
Copy link
Copy Markdown

what instlal-config.yaml changes do we need to use this?

@mjturek
Copy link
Copy Markdown
Author

mjturek commented Nov 10, 2021

what instlal-config.yaml changes do we need to use this?

You just need to set the imageName to the file name in the bucket. For example

imageName: "rhcos-410-84-202111011607-0-ppc64le-powervs.ova.gz"

Currently if you want to use a specific region for the bucket, you can specify it in imageBucketRegion but if you leave that out, it will just use the same region as the VPC.

@mjturek mjturek force-pushed the import-from-cos branch 2 times, most recently from 1d0a3f8 to 014966a Compare November 10, 2021 21:34
Comment thread data/data/powervs/variables-powervs.tf Outdated
Comment thread data/data/powervs/main.tf Outdated
Comment thread pkg/tfvars/powervs/powervs.go Outdated
Comment thread pkg/tfvars/powervs/powervs.go Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masterConfig.Image should be the boot image we create, and not the ova. so this should stay as ImageName, and we'll need a new field for the bucket object name (ImageBucketFileName is fine). ImageName will be the same as pi_image_name ("${var.cluster_id}-boot-image"). ImageBucketFileName will need to come down from the bits that Cory is working on I believe.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's fair, will do

Comment thread data/data/powervs/variables-powervs.tf Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until we have the rhcos bits from cory, what about setting the default to the current ova, and it'll then be easily change if we need to update it before that PR lands?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me, changing now

@clnperez clnperez merged commit 160b690 into openshift-powervs:add-ipi Nov 11, 2021
mjturek added a commit to mjturek/installer that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants